From 52865ab9e98c18f63f2990238047d7e37a87046b Mon Sep 17 00:00:00 2001 From: David Allemang Date: Wed, 3 Apr 2024 16:14:32 -0400 Subject: [PATCH] remove dead comments --- src/gfx.zig | 2 ++ src/main.zig | 38 -------------------------------------- 2 files changed, 2 insertions(+), 38 deletions(-) diff --git a/src/gfx.zig b/src/gfx.zig index 8ec9b96..b780178 100644 --- a/src/gfx.zig +++ b/src/gfx.zig @@ -351,11 +351,13 @@ pub fn copyBuffer( .p_command_buffers = @ptrCast(&cmdbuf), .p_wait_dst_stage_mask = undefined, }; + // creating and submitting a queue for every copy operation seems a bad idea for "streamed" data // gonna want a way to send a copy operation WITH SYNCHRONIZATION PRIMITIVES on a particular queue // see https://stackoverflow.com/a/62183243 // // this may be a misunderstanding on how submission works... + try vkd.queueSubmit(queue, 1, @ptrCast(&si), .null_handle); try vkd.queueWaitIdle(queue); } diff --git a/src/main.zig b/src/main.zig index d0a5422..e07847b 100644 --- a/src/main.zig +++ b/src/main.zig @@ -317,18 +317,9 @@ pub fn main() !void { } const frame: ChainImage = chain.get(index); - // const next_frame: ChainImage = chain.get((index + 1) % chain.len); render(dev, vkd, swapchain, frame, queue) catch |err| switch (err) { error.OutOfDateKHR => { - // try vkd.deviceWaitIdle(dev); - // _ = try vkd.waitForFences( - // dev, - // @intCast(chain.len), - // chain.items(.fence).ptr, - // vk.TRUE, - // std.math.maxInt(u64), - // ); try vkd.deviceWaitIdle(dev); deinit_chain(chain, dev, vkd, pool); @@ -360,40 +351,11 @@ pub fn main() !void { else => |errx| return errx, }; - // var index: u32 = undefined; - // try vkd.acquireNextImageKHR(dev, swapchain, std.math.maxInt(u64), frame., fence); - - // const cmdbuf = cmdbufs[swapchain.image_index]; - - // const state = swapchain.present(cmdbuf) catch |err| switch (err) { - // error.OutOfDateKHR => Swapchain.PresentState.suboptimal, - // else => |narrow| return narrow, - // }; - - // if (state == .suboptimal or extent.width != @as(u32, @intCast(w)) or extent.height != @as(u32, @intCast(h))) { - // extent.width = @intCast(w); - // extent.height = @intCast(h); - // try swapchain.recreate(extent, format); - // - // destroyCommandBuffers(&gc, pool, ally, cmdbufs); - // - // cmdbufs = try createCommandBuffers( - // &gc, - // pool, - // ally, - // vertex_buffer, - // index_buffer, - // pipeline, - // swapchain, - // ); - // } - c.glfwPollEvents(); index = @intCast((index + 1) % chain.len); } - // try swapchain.waitForAllFences(); try vkd.deviceWaitIdle(dev); }