me/qmk_firmware
1
0
Fork 0
forked from mirror/qmk_firmware
Code Pull Requests Activity

Fixes for is31fl3729 LED matrix driver off-by-one errors (#25902)

Browse Source 
Co-authored-by: Evelyn Holloway <dev@evelynonline.ca>
This commit is contained in:
ms-eevee
2026-01-09 18:32:55 -05:00
committed by GitHub
parent 2b6ed67db4
commit df93bfb750
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/led/issi/is31fl3729-mono.c
View File

@@ -107,7 +107,7 @@ void is31fl3729_write_pwm_buffer(uint8_t index) {
// Transmit PWM registers in 11 transfers of 13 bytes. // Transmit PWM registers in 11 transfers of 13 bytes.
// Iterate over the pwm_buffer contents at 13 byte intervals. // Iterate over the pwm_buffer contents at 13 byte intervals.
for (uint8_t i = 0; i <= IS31FL3729_PWM_REGISTER_COUNT; i += 13) { for (uint8_t i = 0; i < IS31FL3729_PWM_REGISTER_COUNT; i += 13) {
#if IS31FL3729_I2C_PERSISTENCE > 0 #if IS31FL3729_I2C_PERSISTENCE > 0
for (uint8_t j = 0; j < IS31FL3729_I2C_PERSISTENCE; j++) { for (uint8_t j = 0; j < IS31FL3729_I2C_PERSISTENCE; j++) {
if (i2c_write_register(i2c_addresses[index] << 1, IS31FL3729_REG_PWM + i, driver_buffers[index].pwm_buffer + i, 13, IS31FL3729_I2C_TIMEOUT) == I2C_STATUS_SUCCESS) break; if (i2c_write_register(i2c_addresses[index] << 1, IS31FL3729_REG_PWM + i, driver_buffers[index].pwm_buffer + i, 13, IS31FL3729_I2C_TIMEOUT) == I2C_STATUS_SUCCESS) break;
@@ -182,7 +182,7 @@ void is31fl3729_set_scaling_register(uint8_t index, uint8_t value) {
// need to do a bit of checking here since 3729 scaling is per CS pin. // need to do a bit of checking here since 3729 scaling is per CS pin.
// not the usual per single LED key as per other ISSI drivers // not the usual per single LED key as per other ISSI drivers
// only enable them, since they should be default disabled // only enable them, since they should be default disabled
int cs_value = (led.v & 0x0F) - 1; int cs_value = (led.v & 0x0F);
driver_buffers[led.driver].scaling_buffer[cs_value] = value; driver_buffers[led.driver].scaling_buffer[cs_value] = value;
driver_buffers[led.driver].scaling_buffer_dirty = true; driver_buffers[led.driver].scaling_buffer_dirty = true;

8
drivers/led/issi/is31fl3729.c
View File

@@ -107,7 +107,7 @@ void is31fl3729_write_pwm_buffer(uint8_t index) {
// Transmit PWM registers in 11 transfers of 13 bytes. // Transmit PWM registers in 11 transfers of 13 bytes.
// Iterate over the pwm_buffer contents at 13 byte intervals. // Iterate over the pwm_buffer contents at 13 byte intervals.
for (uint8_t i = 0; i <= IS31FL3729_PWM_REGISTER_COUNT; i += 13) { for (uint8_t i = 0; i < IS31FL3729_PWM_REGISTER_COUNT; i += 13) {
#if IS31FL3729_I2C_PERSISTENCE > 0 #if IS31FL3729_I2C_PERSISTENCE > 0
for (uint8_t j = 0; j < IS31FL3729_I2C_PERSISTENCE; j++) { for (uint8_t j = 0; j < IS31FL3729_I2C_PERSISTENCE; j++) {
if (i2c_write_register(i2c_addresses[index] << 1, IS31FL3729_REG_PWM + i, driver_buffers[index].pwm_buffer + i, 13, IS31FL3729_I2C_TIMEOUT) == I2C_STATUS_SUCCESS) break; if (i2c_write_register(i2c_addresses[index] << 1, IS31FL3729_REG_PWM + i, driver_buffers[index].pwm_buffer + i, 13, IS31FL3729_I2C_TIMEOUT) == I2C_STATUS_SUCCESS) break;
@@ -184,9 +184,9 @@ void is31fl3729_set_scaling_register(uint8_t index, uint8_t red, uint8_t green,
// need to do a bit of checking here since 3729 scaling is per CS pin. // need to do a bit of checking here since 3729 scaling is per CS pin.
// not the usual per RGB key as per other ISSI drivers // not the usual per RGB key as per other ISSI drivers
// only enable them, since they should be default disabled // only enable them, since they should be default disabled
int cs_red = (led.r & 0x0F) - 1; int cs_red = (led.r & 0x0F);
int cs_green = (led.g & 0x0F) - 1; int cs_green = (led.g & 0x0F);
int cs_blue = (led.b & 0x0F) - 1; int cs_blue = (led.b & 0x0F);
driver_buffers[led.driver].scaling_buffer[cs_red] = red; driver_buffers[led.driver].scaling_buffer[cs_red] = red;
driver_buffers[led.driver].scaling_buffer[cs_green] = green; driver_buffers[led.driver].scaling_buffer[cs_green] = green;